Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle small screenshots in app banners #2821

Open
Kekun opened this issue Mar 31, 2024 · 1 comment
Open

Better handle small screenshots in app banners #2821

Kekun opened this issue Mar 31, 2024 · 1 comment

Comments

@Kekun
Copy link

Kekun commented Mar 31, 2024

I'm working on adding brand colors to some app, and for that I'm using the banner previewer. While doing so I noticed the app's screenshot doesn't look great in the previewer.

Screenshot 2024-03-31 at 13-57-03 Brand color preview Flathub Documentation

The app's screenshot, for reference:
screenshot1

That app has quite a small and narrow window, and there isn't a point in making it larger in any way as it brings nothing to the user and it just makes the app look weird: it's designed to be used as a short, squarish or narrow window.

If I make the window twice as wide we start to see some relevant details of the window, but barely and the screeshot just looks odd:
Screenshot 2024-03-31 at 14-01-23 Brand color preview Flathub Documentation

Capture d’écran du 2024-03-31 14-00-50

I see there's an "Is Fullscreen App" toggle in the previewer, so some apps are special-cased, maybe small/narrow apps could be special-cased too? I don't have any good idea to make the screenshot look decent and attractive in the banner.

@Kekun Kekun changed the title Better handle small windowsin app banners Better handle small screenshots in app banners Mar 31, 2024
@bertob
Copy link

bertob commented Apr 20, 2024

For screenshots that are wide but not tall, we could probably auto-detect that from the size and switch to a layout that vertically centers it. See also CleoMenezesJr/Aurea#6

Screenshots that are tall but not wide are trickier. The only realistic option that comes to mind is showing multiple portrait screenshots next to each other. This would mean that we require apps to do some pretty specific things though:

  • Have the first 2 or 3 screenshots be portrait
  • Have them all be the same size
  • Make sure they look good next to each other

It could work, but at that point I wonder if this stuff should be explicit in the appstream metadata rather than conventions at the Flathub level...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants