Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic upgrade to libchamplain #345

Open
albfan opened this issue Jan 19, 2023 · 3 comments
Open

automatic upgrade to libchamplain #345

albfan opened this issue Jan 19, 2023 · 3 comments

Comments

@albfan
Copy link

albfan commented Jan 19, 2023

flathub/nl.sarine.gpx-viewer#5

How this is supposed to work, detect an outdated dependency and trigger an update with a PR, show the build problems on CI and expect maintainers to fix it?

@wjt
Copy link
Contributor

wjt commented Jan 19, 2023

That's right.

@albfan
Copy link
Author

albfan commented Jan 19, 2023

But is just a suggestion or something that will brake or discontinue the app if not addressed?

@wjt
Copy link
Contributor

wjt commented Jan 19, 2023

The bot opened the PR because of this block in the manifest:

https://github.com/flathub/nl.sarine.gpx-viewer/blob/master/nl.sarine.gpx-viewer.json#L43-L46

It detected that a newer version of that library is available, and generated the PR. You can just close the PR and it won't reopen it. The app will continue to work.

Looking at the NEWS for libchamplain: the main change seems to be to add libsoup3 support. In some future version of the GNOME runtime, libsoup2 will presumably be removed, and so you'll need to update libchamplain at the same time as switching to such a future runtime version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants