Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render SVG logo #68

Open
koalatux opened this issue Jun 26, 2019 · 4 comments
Open

render SVG logo #68

koalatux opened this issue Jun 26, 2019 · 4 comments

Comments

@koalatux
Copy link

The app currently does not render SVG files as logo.

Screenshot_20190626-230345

@rorist
Copy link
Member

rorist commented Feb 29, 2020

hi,

it may be possible to execute some java using svg or some other stuff. It's quite a difficult task to secure svg. Should be make a class that converts svg to png instead or use a 3rd party that make it right ?

We have to remeber that the spaceapi is user input and even though it's json we're parsing it at some point.

@dbrgn
Copy link
Contributor

dbrgn commented Feb 29, 2020

This is definitely non-trivial and would require to add quite a big SVG parsing and rendering library to the app. SVG is a huge standard. Most SVG libraries also require native code, which increases attack surface complicates distribution because you now need to distribute per-architecture APKs, compiled for the different target platforms.

I would personally prefer if the spaces would simply provide pixel formats for the logos. We could expand the spec to allow multiple logo formats, where I'd require a PNG logo and allow an additional SVG logo.

@koalatux
Copy link
Author

koalatux commented Mar 1, 2020

What about using WebView to render the SVG? Since Android 3.0 WebView supports SVG. Javascript is turned off by default and you may also want to block loading of external resources with the setBlockNetworkLoads (I don't know if this is enough to prevent all malicious stuff, I am not an Android developer).

@dbrgn
Copy link
Contributor

dbrgn commented Mar 1, 2020

Hmm, that could work...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants