Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate the Lassie library from everything else #266

Open
hannahhoward opened this issue May 27, 2023 · 1 comment
Open

Seperate the Lassie library from everything else #266

hannahhoward opened this issue May 27, 2023 · 1 comment
Assignees
Labels
tech debt Non-critical change that can wait to be addressed

Comments

@hannahhoward
Copy link
Collaborator

This is a companion to #256.

Essentially, my thinking is this:

  • when we started this project, we said pkg is the Lassie library, but then we realized we needed to put a bunch of other stuff in there
  • as a result, it's very not clear which folders under pkg are actually part of using lassie as a library
  • I think we need to put everything that goes into Lassie as a library under /pkg/lassie
    • basically if you need it to make a lassie.Lassie, you put it under pkg/lassie
    • my surface read is that covers these folders
      • events
      • session
      • indexerlookup
      • net
      • retriever
      • session
      • types
    • but not
      • aggregateeventrecorder
      • build
      • eventrecorder
      • metrics (which should get deleted see Remove in repo metrics code #255)
      • server
      • storage
      • verifiedcar (though this should probably get moved out of repo to go-car)

This isn't a comment on which of these folders would become internal (in pkg/lassie/internal) but we can think of that as well.

@hannahhoward hannahhoward added the tech debt Non-critical change that can wait to be addressed label May 27, 2023
@bajtos
Copy link
Contributor

bajtos commented Jun 7, 2023

but not

  • server

IIUC, this means that Rusty Lassie will need to (re)create the HTTP server. It would be great if there was an example showing how to write such a server. Even better, can Lassie the library export the request handler that people can add into their own servers (or muxers)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Non-critical change that can wait to be addressed
Projects
None yet
Development

No branches or pull requests

3 participants