Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "tecff-broken-wlan-workaround: add fix for mt7915 bug" #4

Merged
merged 1 commit into from
Jul 5, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,28 +14,28 @@
DEBUG=false

# check if node has wlan
if [ ! -d /sys/class/ieee80211 ] || [ "$(ls -l /sys/class/ieee80211/ | wc -l)" -eq 0 ]; then

Check notice on line 17 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L17 <ShellCheck.SC2012>

Use find instead of ls to better handle non-alphanumeric filenames.
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:17:42: info: Use find instead of ls to better handle non-alphanumeric filenames. (ShellCheck.SC2012)
$($DEBUG) && logger -s -t "$SCRIPTNAME" -p 5 "node has no wlan, aborting."

Check warning on line 18 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L18 <ShellCheck.SC2091>

Remove surrounding $() to avoid executing output (or use eval if intentional).
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:18:2: warning: Remove surrounding $() to avoid executing output (or use eval if intentional). (ShellCheck.SC2091)
exit
fi

# don't do anything while an autoupdater process is running
pgrep autoupdater >/dev/null
if [ "$?" == "0" ]; then

Check notice on line 24 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L24 <ShellCheck.SC2181>

Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:24:6: info: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. (ShellCheck.SC2181)

Check warning on line 24 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L24 <ShellCheck.SC3014>

In POSIX sh, == in place of = is undefined.
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:24:11: warning: In POSIX sh, == in place of = is undefined. (ShellCheck.SC3014)
logger -s -t "$SCRIPTNAME" -p 5 "autoupdater is running, aborting."
exit
fi

# don't run this script if another instance is still running
exec 200<$0

Check failure on line 30 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / runner / shellcheck

[shellcheck (suggestion)] reported by reviewdog 🐶 Raw Output: tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:30:-exec 200<$0 tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:30:+exec 200<"$0"

Check warning on line 30 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L30 <ShellCheck.SC3023>

In POSIX sh, FDs outside 0-9 are undefined.
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:30:6: warning: In POSIX sh, FDs outside 0-9 are undefined. (ShellCheck.SC3023)

Check notice on line 30 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L30 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:30:10: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
flock -n 200
if [ "$?" != "0" ]; then

Check notice on line 32 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L32 <ShellCheck.SC2181>

Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:32:6: info: Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. (ShellCheck.SC2181)
logger -s -t "$SCRIPTNAME" -p 5 "failed to acquire lock, another instance of this script might still be running, aborting."
exit
fi

# check if node uses a wlan driver and gather interfaces and devices
for i in $(ls /sys/class/net/); do

Check failure on line 38 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L38 <ShellCheck.SC2045>

Iterating over ls output is fragile. Use globs.
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:38:10: error: Iterating over ls output is fragile. Use globs. (ShellCheck.SC2045)
# gather a list of interfaces
if [ -n "$WLAN_INTERFACES" ]; then
WLAN_INTERFACES="$WLAN_INTERFACES $i"
Expand All @@ -44,8 +44,8 @@
fi
# gather a list of devices
if expr "$i" : "\(client\|mesh\|owe\)[0-9]" >/dev/null; then
WIRELESS_UCI="$(uci show wireless | grep $i | cut -d"." -f1-2)"

Check failure on line 47 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / runner / shellcheck

[shellcheck (suggestion)] reported by reviewdog 🐶 Raw Output: tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:47:- WIRELESS_UCI="$(uci show wireless | grep $i | cut -d"." -f1-2)" tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:48:- WLAN_DEVICE="$(uci get ${WIRELESS_UCI}.device)" tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:47:+ WIRELESS_UCI="$(uci show wireless | grep "$i" | cut -d"." -f1-2)" tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:48:+ WLAN_DEVICE="$(uci get "${WIRELESS_UCI}".device)"

Check notice on line 47 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L47 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:47:44: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
WLAN_DEVICE="$(uci get ${WIRELESS_UCI}.device)"

Check notice on line 48 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L48 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:48:26: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
if [ -n "$WLAN_DEVICES" ]; then
if ! expr "$WLAN_DEVICES" : ".*${WLAN_DEVICE}.*" >/dev/null; then
WLAN_DEVICES="$WLAN_DEVICES $WLAN_DEVICE"
Expand Down Expand Up @@ -75,9 +75,9 @@
WLANMESHCONNECTIONS=0
for wlan_interface in $WLAN_INTERFACES; do
if expr "$wlan_interface" : "mesh[0-9]" >/dev/null; then
if [ "$(batctl o | egrep "$wlan_interface" | wc -l)" -gt 0 ]; then

Check notice on line 78 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L78 <ShellCheck.SC2196>

egrep is non-standard and deprecated. Use grep -E instead.
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:78:22: info: egrep is non-standard and deprecated. Use grep -E instead. (ShellCheck.SC2196)
WLANMESHCONNECTIONS=1
$($DEBUG) && logger -s -t "$SCRIPTNAME" -p 5 "found wlan mesh partners."

Check warning on line 80 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L80 <ShellCheck.SC2091>

Remove surrounding $() to avoid executing output (or use eval if intentional).
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:80:4: warning: Remove surrounding $() to avoid executing output (or use eval if intentional). (ShellCheck.SC2091)
if [ ! -f "$MESHFILE" ]; then
# create file so we can check later if there was a wlan mesh connection before
touch $MESHFILE
Expand All @@ -89,11 +89,11 @@

# check if there are local wlan batman clients
WLANFFCONNECTIONS=0
WLANFFCONNECTIONCOUNT="$(batctl tl | grep W | wc -l)"

Check notice on line 92 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L92 <ShellCheck.SC2126>

Consider using 'grep -c' instead of 'grep|wc -l'.
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:92:38: info: Consider using 'grep -c' instead of 'grep|wc -l'. (ShellCheck.SC2126)
if [ "$WLANFFCONNECTIONCOUNT" -gt 0 ]; then
# note: this check doesn't know which radio the clients are on
WLANFFCONNECTIONS=1
$($DEBUG) && logger -s -t "$SCRIPTNAME" -p 5 "found batman local clients."

Check warning on line 96 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L96 <ShellCheck.SC2091>

Remove surrounding $() to avoid executing output (or use eval if intentional).
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:96:2: warning: Remove surrounding $() to avoid executing output (or use eval if intentional). (ShellCheck.SC2091)
if [ ! -f "$CLIENTFILE" ]; then
# create file so we can check later if there were batman local clients before
touch $CLIENTFILE
Expand All @@ -104,10 +104,10 @@
WLANPRIVCONNECTIONS=0
for wlan_interface in $WLAN_INTERFACES; do
if expr "$wlan_interface" : "wlan[0-9]" >/dev/null; then
iw dev $wlan_interface station dump 2>/dev/null | grep -q Station

Check failure on line 107 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / runner / shellcheck

[shellcheck (suggestion)] reported by reviewdog 🐶 Raw Output: tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:107:- iw dev $wlan_interface station dump 2>/dev/null | grep -q Station tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:107:+ iw dev "$wlan_interface" station dump 2>/dev/null | grep -q Station

Check notice on line 107 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L107 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:107:10: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
if [ "$?" == "0" ]; then

Check notice on line 108 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L108 <ShellCheck.SC2181>

Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:108:8: info: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. (ShellCheck.SC2181)

Check warning on line 108 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L108 <ShellCheck.SC3014>

In POSIX sh, == in place of = is undefined.
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:108:13: warning: In POSIX sh, == in place of = is undefined. (ShellCheck.SC3014)
WLANPRIVCONNECTIONS=1
$($DEBUG) && logger -s -t "$SCRIPTNAME" -p 5 "found private wlan clients."

Check warning on line 110 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L110 <ShellCheck.SC2091>

Remove surrounding $() to avoid executing output (or use eval if intentional).
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:110:4: warning: Remove surrounding $() to avoid executing output (or use eval if intentional). (ShellCheck.SC2091)
if [ ! -f "$PRIVCLIENTFILE" ]; then
# create file so we can check later if there were private wlan clients before
touch $PRIVCLIENTFILE
Expand All @@ -121,7 +121,7 @@
GWCONNECTION=0
if [ -f /var/gluon/state/has_default_gw4 ] && [ -f /var/gluon/state/can_reach_ntp ]; then
GWCONNECTION=1
$($DEBUG) && logger -s -t "$SCRIPTNAME" -p 5 "found a batman gateway and can ping at least one of the NTP servers."

Check warning on line 124 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L124 <ShellCheck.SC2091>

Remove surrounding $() to avoid executing output (or use eval if intentional).
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:124:2: warning: Remove surrounding $() to avoid executing output (or use eval if intentional). (ShellCheck.SC2091)
if [ ! -f "$GWFILE" ]; then
# create file so we can check later if there was a reachable gateway before
touch $GWFILE
Expand All @@ -135,7 +135,7 @@
WLANRESTART=1
logger -s -t "$SCRIPTNAME" -p 5 "found no wlan connection, but there was one before."
else
$($DEBUG) && logger -s -t "$SCRIPTNAME" -p 5 "found no wlan connection, but that is no reason to act, because this node had no wlan connections since its last reboot."

Check warning on line 138 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L138 <ShellCheck.SC2091>

Remove surrounding $() to avoid executing output (or use eval if intentional).
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:138:3: warning: Remove surrounding $() to avoid executing output (or use eval if intentional). (ShellCheck.SC2091)
fi
fi
if [ "$GWCONNECTION" -eq 0 ]; then
Expand All @@ -144,21 +144,10 @@
WLANRESTART=1
logger -s -t "$SCRIPTNAME" -p 5 "found no working gateway connection, but there was one before."
else
$($DEBUG) && logger -s -t "$SCRIPTNAME" -p 5 "found no working gateway connection, but that is no reason to act, because this node had no gateway since its last reboot."

Check warning on line 147 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L147 <ShellCheck.SC2091>

Remove surrounding $() to avoid executing output (or use eval if intentional).
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:147:3: warning: Remove surrounding $() to avoid executing output (or use eval if intentional). (ShellCheck.SC2091)
fi
fi

if ! cat /sys/kernel/debug/ieee80211/phy*/mt76/rf_regval > /dev/null; then
# https://github.com/freifunk-gluon/gluon/issues/3154#issuecomment-2125452973
logger -p 0 -t "$SCRIPTNAME" "wifi seems crashed; reloading driver";
# delete old hostapd files, as they are not needed anymore
# and mangle with the ffac-ssid-changer
rmmod mt7915e && rm /var/run/hostapd-*.conf* && modprobe mt7915e
# directly restart wifi
WLANRESTART=1
touch $RESTARTFILE
fi

if [ ! -f "$RESTARTFILE" ] && [ "$WLANRESTART" -eq 1 ]; then
# delaying wlan restart until the next script run
touch $RESTARTFILE
Expand All @@ -172,11 +161,11 @@
rm -f $RESTARTFILE
touch $RESTARTINFOFILE
for wlan_device in $WLAN_DEVICES; do
wifi down $wlan_device

Check failure on line 164 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / runner / shellcheck

[shellcheck (suggestion)] reported by reviewdog 🐶 Raw Output: tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:164:- wifi down $wlan_device tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:164:+ wifi down "$wlan_device"

Check notice on line 164 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L164 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:164:13: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
done
sleep 1
for wlan_device in $WLAN_DEVICES; do
wifi up $wlan_device

Check failure on line 168 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / runner / shellcheck

[shellcheck (suggestion)] reported by reviewdog 🐶 Raw Output: tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:168:- wifi up $wlan_device tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:168:+ wifi up "$wlan_device"

Check notice on line 168 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L168 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.
Raw output
./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:168:11: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
done
elif [ -f "$RESTARTFILE" ]; then
logger -s -t "$SCRIPTNAME" -p 5 "everything seems to be ok again."
Expand Down
Loading