New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "tecff-broken-wlan-workaround: add fix for mt7915 bug" #4

Merged

maurerle merged 1 commit into main from revert-mt7915-in-general

Jul 5, 2024

Merged

Revert "tecff-broken-wlan-workaround: add fix for mt7915 bug" #4

Revert "tecff-broken-wlan-workaround: add fix for mt7915 bug"

GitHub Actions / shellcheck failed Jul 5, 2024 in 1s

reviewdog [shellcheck] report

reported by reviewdog 🐶

Findings (23)

tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|17 col 42| Use find instead of ls to better handle non-alphanumeric filenames.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|18 col 2| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|24 col 6| Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|24 col 11| In POSIX sh, == in place of = is undefined.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|30 col 6| In POSIX sh, FDs outside 0-9 are undefined.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|30 col 10| Double quote to prevent globbing and word splitting.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|32 col 6| Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|38 col 10| Iterating over ls output is fragile. Use globs.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|47 col 44| Double quote to prevent globbing and word splitting.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|48 col 26| Double quote to prevent globbing and word splitting.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|78 col 22| egrep is non-standard and deprecated. Use grep -E instead.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|80 col 4| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|92 col 38| Consider using 'grep -c' instead of 'grep|wc -l'.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|96 col 2| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|107 col 10| Double quote to prevent globbing and word splitting.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|108 col 8| Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|108 col 13| In POSIX sh, == in place of = is undefined.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|110 col 4| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|124 col 2| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|138 col 3| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|147 col 3| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|164 col 13| Double quote to prevent globbing and word splitting.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|168 col 11| Double quote to prevent globbing and word splitting.

Filtered Findings (12)

tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|12 col 7| Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|12 col 12| In POSIX sh, == in place of = is undefined.
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|24 col 1| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|26 col 2| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|34 col 2| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|39 col 1| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|41 col 6| Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|41 col 11| In POSIX sh, == in place of = is undefined.
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|55 col 3| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|74 col 2| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-general-workaround/files/lib/gluon/state/check.d/can_reach_ntp|3 col 13| Double quote to prevent globbing and word splitting.
tecff-general-workaround/files/lib/gluon/state/check.d/can_reach_ntp|4 col 7| Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.

Annotations

Check notice on line 17 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L17 <ShellCheck.SC2012>

Use find instead of ls to better handle non-alphanumeric filenames.

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:17:42: info: Use find instead of ls to better handle non-alphanumeric filenames. (ShellCheck.SC2012)

Check warning on line 18 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L18 <ShellCheck.SC2091>

Remove surrounding $() to avoid executing output (or use eval if intentional).

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:18:2: warning: Remove surrounding $() to avoid executing output (or use eval if intentional). (ShellCheck.SC2091)

Check notice on line 24 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L24 <ShellCheck.SC2181>

Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:24:6: info: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. (ShellCheck.SC2181)

Check warning on line 24 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L24 <ShellCheck.SC3014>

In POSIX sh, == in place of = is undefined.

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:24:11: warning: In POSIX sh, == in place of = is undefined. (ShellCheck.SC3014)

Check warning on line 30 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L30 <ShellCheck.SC3023>

In POSIX sh, FDs outside 0-9 are undefined.

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:30:6: warning: In POSIX sh, FDs outside 0-9 are undefined. (ShellCheck.SC3023)

Check notice on line 30 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L30 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:30:10: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check notice on line 32 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L32 <ShellCheck.SC2181>

Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:32:6: info: Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. (ShellCheck.SC2181)

Check failure on line 38 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L38 <ShellCheck.SC2045>

Iterating over ls output is fragile. Use globs.

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:38:10: error: Iterating over ls output is fragile. Use globs. (ShellCheck.SC2045)

Check notice on line 47 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L47 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:47:44: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check notice on line 48 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L48 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:48:26: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check notice on line 78 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L78 <ShellCheck.SC2196>

egrep is non-standard and deprecated. Use grep -E instead.

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:78:22: info: egrep is non-standard and deprecated. Use grep -E instead. (ShellCheck.SC2196)

Check warning on line 80 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L80 <ShellCheck.SC2091>

Remove surrounding $() to avoid executing output (or use eval if intentional).

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:80:4: warning: Remove surrounding $() to avoid executing output (or use eval if intentional). (ShellCheck.SC2091)

Check notice on line 92 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L92 <ShellCheck.SC2126>

Consider using 'grep -c' instead of 'grep|wc -l'.

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:92:38: info: Consider using 'grep -c' instead of 'grep|wc -l'. (ShellCheck.SC2126)

Check warning on line 96 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L96 <ShellCheck.SC2091>

Remove surrounding $() to avoid executing output (or use eval if intentional).

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:96:2: warning: Remove surrounding $() to avoid executing output (or use eval if intentional). (ShellCheck.SC2091)

Check notice on line 107 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L107 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:107:10: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check notice on line 108 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L108 <ShellCheck.SC2181>

Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:108:8: info: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. (ShellCheck.SC2181)

Check warning on line 108 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L108 <ShellCheck.SC3014>

In POSIX sh, == in place of = is undefined.

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:108:13: warning: In POSIX sh, == in place of = is undefined. (ShellCheck.SC3014)

Check warning on line 110 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L110 <ShellCheck.SC2091>

Remove surrounding $() to avoid executing output (or use eval if intentional).

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:110:4: warning: Remove surrounding $() to avoid executing output (or use eval if intentional). (ShellCheck.SC2091)

Check warning on line 124 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L124 <ShellCheck.SC2091>

Remove surrounding $() to avoid executing output (or use eval if intentional).

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:124:2: warning: Remove surrounding $() to avoid executing output (or use eval if intentional). (ShellCheck.SC2091)

Check warning on line 138 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L138 <ShellCheck.SC2091>

Remove surrounding $() to avoid executing output (or use eval if intentional).

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:138:3: warning: Remove surrounding $() to avoid executing output (or use eval if intentional). (ShellCheck.SC2091)

Check warning on line 147 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L147 <ShellCheck.SC2091>

Remove surrounding $() to avoid executing output (or use eval if intentional).

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:147:3: warning: Remove surrounding $() to avoid executing output (or use eval if intentional). (ShellCheck.SC2091)

Check notice on line 164 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L164 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:164:13: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check notice on line 168 in tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh

github-actions / shellcheck

[shellcheck] tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh#L168 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.

Raw output


            ./tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh:168:11: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

View more details on GitHub Actions