Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5pt,6pt] Implement new UI for selecting signals #188

Closed
3 tasks done
ivan-cukic opened this issue Jun 28, 2024 · 1 comment · Fixed by #189
Closed
3 tasks done

[5pt,6pt] Implement new UI for selecting signals #188

ivan-cukic opened this issue Jun 28, 2024 · 1 comment · Fixed by #189
Assignees
@ivan-cukic @vimpostor
Milestone
CALL#4 - OP OpenD...

Comments

@ivan-cukic
Copy link
Contributor

ivan-cukic commented Jun 28, 2024 •
edited by vimpostor
Loading

As designed in #120

After the patch:

  • the UI should be able to load all known signals in memory
  • filter signals according to the current search and filtering
  • to add the selected signal to the flowgraph
signals.webm
@RalphSteinhagen RalphSteinhagen changed the title Implement new UI for selecting signals [5pt] Implement new UI for selecting signals Jun 28, 2024
@vimpostor vimpostor mentioned this issue Jul 24, 2024
Merged
@vimpostor vimpostor changed the title [5pt] Implement new UI for selecting signals [5pt,6pt] Implement new UI for selecting signals Jul 25, 2024
@ivan-cukic
Copy link
Contributor Author

While working on this, some things WRT UI improvement were detected:

RalphSteinhagen pushed a commit that referenced this issue Jul 30, 2024
@vimpostor @ivan-cukic
Implement new UI for selecting signals (#189)
c39e885 

Implements design as outlined in #188

Set OPENDIGITIZER_LOAD_TEST_SIGNALS=1 for testing.

The rendered columns are the name and comment for now, but can be changed if desired.

* Basic UI components for signal selection
* Basic text-based searching
* Filtering on fields
* Some warning fixes
* Hook up SignalSelector UI to DNS results
* Remove std::ranges usage
  The CI complains about it, even though it runs gcc14 already.
* Disable MD* signals as they are not supported
* Use a proper window title
* Show more columns in the signal selection
  Also generate about 100k signals for testing.
* Fully support GR4 block type parameters

Signed-off-by: Ivan Čukić <[email protected]>
Signed-off-by: Magnus Groß <[email protected]>
Co-authored-by: Ivan Čukić <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivan-cukic ivan-cukic

@vimpostor vimpostor

Labels
None yet
Projects
Digitizer Reimplementation
Status: ✅ QA-Accepted/Merged (∞)
Milestone
CALL#4 - OP OpenDigitizer Integration...
Development

Successfully merging a pull request may close this issue.

Implement new UI for selecting signals fair-acc/opendigitizer
3 participants
@ivan-cukic @vimpostor @RalphSteinhagen