Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont use GR_LOG_* inside real-time thread/handlers which might log in a massive rate #102

Open
alexxcons opened this issue Jan 31, 2022 · 1 comment
Open

Dont use GR_LOG_* inside real-time thread/handlers which might log in a massive rate #102

alexxcons opened this issue Jan 31, 2022 · 1 comment
Labels
external priority::low task

Comments

@alexxcons
Copy link
Collaborator

replace text-based logging in "hot-paths" entirely.

Other possible options could be:

  • To raise a flag on the acquisition_info tag of all concerned channels (Or even add an error message?)
  • replace the currentl logging with a proper metrics logger (<-> logged via prometheus) and server-local diagnostics property.
@alexxcons alexxcons mentioned this issue Jan 31, 2022
Merged
@alexxcons
Copy link
Collaborator Author

Once in action, it might be worth to possibly re-add this log message: #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external priority::low task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexxcons