-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relay 18] Relay Resolver return type not getting derived from resolver function #4790
Comments
We are on the following: "react-relay": "^18.0.0",
"relay-runtime": "^18.0.0",
"relay-compiler": "^18.0.0"
"@types/react-relay": "^16.0.6",
"@types/relay-runtime": "^17.0.4", Could the issue be due to the |
Thanks for the report! Let me see if I can repro/fix. |
I think this relates to these lines:
We actually have a few integration tests which currently show this broken behavior. For example: @drewatk do you want to take a look at this? See also: #4772 |
Note: Removing those |
Drew is on holiday, but I submitted a fix #4791. I ran into this issue yesterday and realised we made a mistake by removing it, thinking it was always unused. Removed @captbaritone might make sense to have a Typescript validation check on the generated files so CI can catch this? (That is after we fix type checking those files and remove the @ts-nocheck.) |
@captbaritone any updates on this issue, please? Are we good to merge the fix? It is currently blocking us from upgrading to Relay 18. |
@waynezhang1995 it was fixed in this commit @captbaritone can hopefully release a new version that includes it. |
Creating issues for Relay
Questions regarding how to use Relay and/or GraphQL
We are experimenting with Relay 18 and have noticed that the return type of a Relay resolver with
RelayResolverValue
is no longer being derived in the generated TypeScript type definitionFor example:
Given the following relay resolver implementation
In the generated relay artifact that references the
contactInfo
Relay used to derive the return type
import { contactInfo as personalDetailsContactInfoResolverType } from "../RelayResolvers";
, but this is now missing in Relay 18Appreciate any insights. Thanks
Reporting issues with Relay
We will be using GitHub Issues for our public bugs. We will keep a close eye on this and try to make it clear when we have an internal fix in progress. Before filing a new issue, make sure an issue for your problem doesn't already exist.
The best way to get your bug fixed is to provide a reduced test case. To make reproduction simple for you, and set-up simple for Relay's maintainers, you can use Glitch:
https://glitch.com/edit/#!/remix/relay-starter-kit
You can also provide a public repository with a runnable example.
Security bugs
Facebook has a bounty program for the safe disclosure of security bugs. With that in mind, please do not file public issues; go through the process outlined on that page.
The text was updated successfully, but these errors were encountered: