Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new build system #920

Open
leavez opened this issue Oct 22, 2018 · 1 comment
Open

Support new build system #920

leavez opened this issue Oct 22, 2018 · 1 comment
Assignees
@alickbass

Comments

@leavez
Copy link

leavez commented Oct 22, 2018 •
edited
Loading

when using the new build system in Xcode, which is default for xcode 10, it has an build error

error: Multiple commands produce '/Users/AAA/Library/Developer/Xcode/DerivedData/CKTableViewTransactionalDataSource-hfnosmzcdvuxuaanjgxnwmxagvqk/Build/Products/Debug-iphonesimulator/ComponentKit/ComponentKit.framework/Info.plist':
1) Target 'ComponentKit' (project 'Pods') has copy command from '/Users/AAA/pp/CKTableViewTransactionalDataSource/Example/Pods/ComponentKit/ComponentKit/Info.plist' to '/Users/AAA/Library/Developer/Xcode/DerivedData/CKTableViewTransactionalDataSource-hfnosmzcdvuxuaanjgxnwmxagvqk/Build/Products/Debug-iphonesimulator/ComponentKit/ComponentKit.framework/Info.plist'
2) Target 'ComponentKit' (project 'Pods') has process command with output '/Users/AAA/Library/Developer/Xcode/DerivedData/CKTableViewTransactionalDataSource-hfnosmzcdvuxuaanjgxnwmxagvqk/Build/Products/Debug-iphonesimulator/ComponentKit/ComponentKit.framework/Info.plist'

It's because the new build system cannot allow the info.plist being into 'Compile Sources'. In the podfile, the following could lead this problem. We should exclude the info.plist form source_files

 s.source_files = 'ComponentKit/**/*', 'ComponentTextKit/**/*'
@alickbass
Copy link
Contributor

Great! Thanks for submitting this issue! I will take a look at it!

@sebikaplun sebikaplun mentioned this issue Nov 25, 2018
Closed
facebook-github-bot pushed a commit that referenced this issue Dec 3, 2018
@facebook-github-bot
Fix new build system compatiblity (#922)
ea5c130 
Summary:
This issue
#920

was being caused because the podspec includes all files, so the Info.plist was also being imported and the XCode warned that 2 info.plist were added the the project.

This PR excludes the plist file
Pull Request resolved: #922

Differential Revision: D13302813

Pulled By: alickbass

fbshipit-source-id: 00eb7445115273e76bcb8a0e58b13d8896ded8b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alickbass alickbass

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leavez @alickbass