Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Allow custom filters #154

Open
pmuir opened this issue Mar 19, 2017 · 2 comments
Open

Allow custom filters #154

pmuir opened this issue Mar 19, 2017 · 2 comments
Milestone

Comments

@pmuir
Copy link
Contributor

pmuir commented Mar 19, 2017

The current filters are not extensible, meaning that if a consumer wants to extend them, they have to replace them. Instead, allow consumers to specify additional filter configs, perhaps via a callback.

Depends on #153

@dlabrecq
Copy link
Collaborator

@pmuir Are you speaking about the filter component in ngx-widgets or the runtime console in general?

The filter component allows the user to make a simple selection from a list of options. For this, the component only needs a display value and an ID (optional). When the user selects an option, an event is generated with the filter config provided. However, the filter doesn't need additional config properties to do this. How the app implements the filter selection is up to you.

Are you looking to stuff more data in the filter config for convenience (e.g., a property of type any)? Is a callback what you're looking for?

@pmuir
Copy link
Contributor Author

pmuir commented Mar 19, 2017

@dlabrecq The filter component in ngx-widgets is great, and I like the model.

I'm actually talking about the way filters are going to work in this console (which aren't based on ngx-widgets at all).

But to make this a bit more abstract - basically if a Angular component A includes a filter in it, and then A itself is included in component B, how can B adjust the filter?

Actually, I think @ViewChild will do what I'm thinking about, so I suspect it's just a case of always making the filter config available on the same variable - i.e. a standard impl pattern. In that case doing #153 may be enough.

@pmuir pmuir modified the milestones: fabric8-ui integration, Summer Mar 20, 2017
@dlabrecq dlabrecq removed their assignment Jun 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants