Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Streams are repeating themselves #151

Open
pmuir opened this issue Mar 19, 2017 · 4 comments
Open

Streams are repeating themselves #151

pmuir opened this issue Mar 19, 2017 · 4 comments
Assignees

Comments

@pmuir
Copy link
Contributor

pmuir commented Mar 19, 2017

I'm seeing multiple identical events being sent down streams. Normally this is caused by a lack of multicast support.

@pmuir pmuir added this to the fabric8-ui integration milestone Mar 19, 2017
@jstrachan
Copy link
Contributor

Got an example of a stream with dupes? I have seen a few initial events with empty collections we should be able to filter out.

We do join quite a few streams together with combineLatest (e.g. Deployment + Service - or now Deployment + Service + Route) so that the main object may appear mostly similar (e.g. the Deployment) on multipole events but we enrich with the exposeUrl so we can link to how to open the web app/REST API of a deployment - so it might look a dupe but might not be if you look really close?

@pmuir
Copy link
Contributor Author

pmuir commented Mar 20, 2017

For example deploymentStore.loadAll() emits about 10-15 times in quick succession, slowly building up the model. This is without any changes to anything. I would expect a single emission here. Whilst the emissions may not be technically duplicates, as a consumer of the API I shouldn't see them.

Right now I just debounce the stream for about 300ms to get the last one, but this is sucky.

@jstrachan
Copy link
Contributor

yeah - Deployment is the trickiest one as its joining Deployments + DeploymentConfigs + Services + Routes + ActiveRoute namespace. I'm pretty sure we're unnecessarily exposing events on startup though too

@pmuir
Copy link
Contributor Author

pmuir commented Mar 21, 2017

I'm just cleaning up some of the integration work I did over the weekend then I will look at this.

@pmuir pmuir self-assigned this Mar 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants