Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include routes and Noticed::Translation in Noticed::Ephemeral #485

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

ghiculescu
Copy link
Contributor

@ghiculescu ghiculescu commented Sep 6, 2024

Ooops, I should have included this in #484, sorry.

Matches

include Translation

Ooops, I should have included this in excid3#484, sorry.
@ghiculescu ghiculescu changed the title Include Noticed::Translation in Noticed::Ephemeral Include routes and Noticed::Translation in Noticed::Ephemeral Sep 6, 2024
@excid3
Copy link
Owner

excid3 commented Sep 6, 2024

Ah yep, missed that too.

I also just realized, I don't think we include the url_helpers or translation in Event::Notification which we probably should do too.

Nevermind, we're already including those in Noticed::Notification

@excid3 excid3 merged commit 02027a3 into excid3:main Sep 6, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants