Adds webhook delivery method #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vickyonit
force-pushed
the
add_webhook_delivery_method
branch
from
e715f89
to
c8ddd9e
Compare
vickyonit
force-pushed
the
add_webhook_delivery_method
branch
from
c8ddd9e
to
332d5f8
Compare
|
@excid3 Merge? |
|
This looks useful. Would be great if it was merged. |
|
Thanks. This will allow the use of my current favourite open source project: https://github.com/binwiederhier/ntfy Hands down the simplest way to send notifications |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @excid3 ,
This PR adds webhook generic functionality as requested in this issue 213.
Current implementation considers the notification to be delivered to one webhook url alone.
Should we support multiple URL delivery?