Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpanNameFunc only called WithTrimSQLInSpanName #32

Open
shagohead opened this issue Apr 19, 2024 · 0 comments
Open

SpanNameFunc only called WithTrimSQLInSpanName #32

shagohead opened this issue Apr 19, 2024 · 0 comments

Comments

@shagohead
Copy link

Thank you for pgx instrumentation!

Looks like WithSpanNameFunc will not work without WithTrimSQLInSpanName. Which is not obvious (and not documented). And for me it seems that this coupling is unnecessary.

What you're think about that?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shagohead