add prometheus extension #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costela
force-pushed
the
leo.antunes/add-prometheus-extension
branch
2 times, most recently
from
8a84b86
to
c7f67f4
Compare
costela
force-pushed
the
leo.antunes/add-prometheus-extension
branch
from
c7f67f4
to
ae3723c
Compare
obitech
reviewed
Nov 9, 2023
Co-authored-by: Alexander Knipping <[email protected]>
costela
force-pushed
the
leo.antunes/add-prometheus-extension
branch
from
36110fb
to
2f24eed
Compare
totallyunknown
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the API to export the necessary parts for a "middleware" inspired extension approach.
It also adds the first such extension to expose prometheus metrics.
hoglet.NewCircuitnow also returns an error. While not as ergonomic as before, this change is necessary to allow errors to bubble up in some edge cases, like prometheus registering.The API looks like this 📖 as of the current head in this branch.
Closes #2