implement imul_r16_rm16 #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evmar
reviewed
Sep 15, 2024
| @@ -808,32 +808,44 @@ pub fn imul_rm8(cpu: &mut CPU, mem: Mem, instr: &Instruction) { | |||
| cpu.regs.set16(Register::AX, res); | |||
| } | |||
|
|
|||
| fn imul_trunc(x: i32, y: i32, _flags: &mut Flags) -> i32 { | |||
| fn imul_trunc_32(x: i32, y: i32, _flags: &mut Flags) -> i32 { | |||
There was a problem hiding this comment.
Take a look at functions like this, which are generic over the types of integers:
retrowin32/x86/src/ops/math.rs
Line 51 in b998e57
In particular that will let the 16-bit and 32-bit versions will share the (TODO) flag-setting code.
...Also, if your program is calling imul, it might need those flags set, so I filed #57 with some notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably needs some extra scrutiny because I have no idea what I'm doing here 😅