Loadpoint: add enable/disable delay apis #16396
Open
+129
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naltatis
reviewed
Sep 28, 2024
| "disableThreshold": {"POST", "/disable/threshold/{value:-?[0-9.]+}", floatHandler(pass(lp.SetDisableThreshold), lp.GetDisableThreshold)}, | ||
| "disableDelay": {"POST", "/disable/delay/{value:[0-9smh]+}", durationHandler(pass(lp.SetDisableDelay), lp.GetDisableDelay)}, |
There was a problem hiding this comment.
Lass uns hier nicht das proprietäre Go-Durationformat nutzen und lieber auf Sekunden gehen. Die sollten in ganzzahlig vollkommen ausreichend sein und machen die API einfacher.
|
Mich überrascht, dass wir diese API noch gar nicht hatte. |
naltatis
approved these changes
Sep 28, 2024
|
|
|
Config UI: Im Loadpoint Branch sind sowohl Threshold als auch Delay bereits enthalten. Also kein Extra Todo hier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auf Anfrage. Falls wir das umsetzen wollen fehlt natürlich die Persistenz fürs Config UI.