Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password as arguments accessible via shell history #33

Open
valefar-on-discord opened this issue May 4, 2024 · 2 comments
Open

Password as arguments accessible via shell history #33

valefar-on-discord opened this issue May 4, 2024 · 2 comments

Comments

@valefar-on-discord
Copy link
Collaborator

Forward from:

The 2020 Audit of staking-deposit-cli mentioned not allowing users to use command line arguments to specify passwords. Doing so would make the password accessible through the bash history.

A potential solution is to remove the option for mnemonic password and keystore passwords are input arguments and only allow them as inputs when running the CLI unless the user is executing with non-interactive enabled.

@remyroy
Copy link
Member

remyroy commented Jun 18, 2024

I like the idea of restricting those password flags only when running this under the non-interaction option. This would have to be well documented.

@yorickdowne
Copy link

We can't restrict --mnemonic_password, as that's the only way a user can input it. That user may not want to run --non_interactive. This is a niche use however, extremely so.

We can restrict --keystore_password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants