From a4cb4002dee90c501f67c0bef713e045303f37aa Mon Sep 17 00:00:00 2001 From: Rob Pilling Date: Mon, 17 Jul 2023 20:06:32 +0100 Subject: [PATCH] Guard against Bangle.setUI({ }) Following on from #2389, this makes it clear that while `setUI()` can be used to reset the UI, `setUI({})` cannot, and must always specify `mode` (amongst other options). --- libs/js/banglejs/Bangle_setUI_F18.js | 1 + libs/js/banglejs/Bangle_setUI_Q3.js | 1 + 2 files changed, 2 insertions(+) diff --git a/libs/js/banglejs/Bangle_setUI_F18.js b/libs/js/banglejs/Bangle_setUI_F18.js index 77c7a77837..6c34826247 100644 --- a/libs/js/banglejs/Bangle_setUI_F18.js +++ b/libs/js/banglejs/Bangle_setUI_F18.js @@ -3,6 +3,7 @@ if ("object"==typeof mode) { options = mode; mode = options.mode; + if (!mode) throw new Error("Missing mode in setUI({...})"); } var redraw = true; if (global.WIDGETS && WIDGETS.back) { diff --git a/libs/js/banglejs/Bangle_setUI_Q3.js b/libs/js/banglejs/Bangle_setUI_Q3.js index f5d3332493..4fd1c4c461 100644 --- a/libs/js/banglejs/Bangle_setUI_Q3.js +++ b/libs/js/banglejs/Bangle_setUI_Q3.js @@ -3,6 +3,7 @@ if ("object"==typeof mode) { options = mode; mode = options.mode; + if (!mode) throw new Error("Missing mode in setUI({...})"); } var redraw = true; if (global.WIDGETS && WIDGETS.back) {