Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTIC_RETENTION_HOURS is missing from default.env.sh file (homebrew macOS) #138

Open
johnsturgeon opened this issue Mar 18, 2024 · 6 comments

Comments

@johnsturgeon
Copy link

I just installed via homebrew on my mac and I didn't see the variable: RESTIC_RETENTION_HOURS in the file. I'm wondering if this is an oversight, or if it's intentional for macOS?

Copy link

Issue is stale; will soon close.

@github-actions github-actions bot added the Stale label Sep 15, 2024
@d4rkd3v1l
Copy link

I recently faced the same issue. After looking into this, I noticed, that the "brew version" still references an old version (7.3.3) where this variable was actually not there (yet).
So this repo would need to be updated in order to fix that. Unfortunately IDK how to create a release there, if someone other than the maintainer can do so in the first place (what I also don't know).

@erikw
Copy link
Owner

erikw commented Sep 16, 2024

Hey, for reasons I won’t have computer access for a while, only on my phone. So I’m unable to fix at this point.

As a workaround, you could for my homebrew repo and run the tool chain as described in the README there to build a new bottled release that points to the latest version in this repo :)

@d4rkd3v1l
Copy link

d4rkd3v1l commented Sep 16, 2024

Thanks for your quick follow up!
Alright.. I bumped the version there.

1 workflow awaiting approval
This workflow requires approval from a maintainer. [Learn more about approving workflows.]> (https://docs.github.com/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks)

erikw/homebrew-tap#27
erikw/homebrew-tap#28

@erikw
Copy link
Owner

erikw commented Sep 16, 2024

Thank you so much @d4rkd3v1l !

it looks like https://github.com/erikw/homebrew-tap/blob/main/.github/workflows/publish.yml needs to be updated to double quote the git commands, according to that style checker that failed in the PR. Could you maybe make a PR? :).

This must be something new as these GitHub workflows did work in the past.

It’s too cumbersome to fix with a mobile phone, sorry :)

@d4rkd3v1l
Copy link

Here you go erikw/homebrew-tap#29

@github-actions github-actions bot removed the Stale label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants