Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate code in rpc::EVMExecutor and ExecutionProcessor #2304

Closed
canepat opened this issue Sep 4, 2024 · 0 comments · Fixed by #2364
Closed

Deduplicate code in rpc::EVMExecutor and ExecutionProcessor #2304

canepat opened this issue Sep 4, 2024 · 0 comments · Fixed by #2364
Assignees
Labels
maintenance Some maintenance work (fix, refactor, rename, test...) priority:medium Issue or task currently not too important

Comments

@canepat
Copy link
Member

canepat commented Sep 4, 2024

For historical reasons, the simulated block and transaction execution necessary to implement many relevant JSON-RPC API endpoints (e.g. eth_call, eth_estimateGas, trace_call, trace_block...) is captured in rpc::EVMExecutor class, which unfortunately contains quite a lot of duplicated code wrt ExecutionProcessor from core package.

We should investigate if it's feasible to merge these two abstraction into a single one.

See also #2284 (comment)

@canepat canepat added maintenance Some maintenance work (fix, refactor, rename, test...) priority:medium Issue or task currently not too important labels Sep 4, 2024
@bzawisto bzawisto self-assigned this Sep 19, 2024
@bzawisto bzawisto linked a pull request Sep 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...) priority:medium Issue or task currently not too important
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants