Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating mprans to xtensor #1076

Open
2 of 5 tasks
JohanMabille opened this issue Jan 30, 2020 · 4 comments
Open
2 of 5 tasks

Migrating mprans to xtensor #1076

JohanMabille opened this issue Jan 30, 2020 · 4 comments

Comments

@JohanMabille
Copy link
Member

JohanMabille commented Jan 30, 2020

This issue is meant to track the migration of the mprans module to xtensor. This will be splitted in many steps to ease the merge of PRs and avoid having too many conflicts.

  • Replace C-style arrays with pyarray in the C++ api exposed to Python
  • Replace all the arguments with a dictionnary of arguments
  • Move implementations to cpp files
  • Propagate pyarray to the implementation
  • Simplify the implementation based on xtensor API.
@cekees
Copy link
Member

cekees commented Jan 30, 2020

Thanks or this @JohanMabille . I know we discussed the dictionary of arguments approach. Do you have a prototype of this yet, say for calculateResidual of RANS2P?

@JohanMabille
Copy link
Member Author

JohanMabille commented Jan 30, 2020

Not yet, binding a map of pyarrays to a dictionnary of numpy arrays does not prevent the copy of numpy arrays when called from the Python side. I know how to fix that but it won't be immediate, thus my question in #1068

@cekees
Copy link
Member

cekees commented Feb 17, 2020

@tridelat, can you take a shot at helping @JohanMabille add the xtensor dependencies to the stack as proper hashdist recipes and remove get_xtensor.sh? I think we should do this before the release. Here's an example of a recipe that copies header files to the artifact direction in the install target: https://github.com/erdc/stack/blob/master/pkgs/daetk/daetk.yaml

/cc @zhang-alvin

@tridelat
Copy link
Member

@cekees @JohanMabille see erdc/stack#43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants