Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using InitDb in tests #1687

Open
andchiind opened this issue Jul 24, 2024 · 0 comments
Open

Stop using InitDb in tests #1687

andchiind opened this issue Jul 24, 2024 · 0 comments
Assignees
Labels
backend Backend related functionality improvement Improvement to existing functionality

Comments

@andchiind
Copy link
Contributor

Describe the improvement you would like to see
We are still using values from initDb when running our unit tests, in particular robot models. This can be quite annoying as changing initDb is useful for performing manual tests and it is not obvious which values are expected in the unit tests. It is for instance expected that we do not use the battery or pressure range limits, otherwise the tests in MissionTests fail. It is better in my opinion to only use data records created in mocks and utility functions within the testing folder.

How will this change existing functionality?
It will better separate the tests from the rest of the project files and it will make it more clear where the values being tested are defined.

How will this improvement affect the current Threat Model?
N/A

@andchiind andchiind added backend Backend related functionality improvement Improvement to existing functionality labels Jul 24, 2024
@andchiind andchiind self-assigned this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality improvement Improvement to existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant