Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite map service #1578

Open
5 tasks
Tracked by #1575
eivindsjovold opened this issue May 2, 2024 · 1 comment
Open
5 tasks
Tracked by #1575

Rewrite map service #1578

eivindsjovold opened this issue May 2, 2024 · 1 comment
Labels
breaking-change A breaking change which introduces changes to the public APIs epic improvement Improvement to existing functionality

Comments

@eivindsjovold
Copy link
Contributor

eivindsjovold commented May 2, 2024

Describe the improvement you would like to see
Currently the map service is dependant on loading png images from an azure blob service. Rewrite this to be more flexible for non-Equinorian users. The service then approxes position from pixels in image.
These separate issues will make MapService not dependant on BlobService:

  • Write a storage interface for MapService, where in-memory storage is an option. In-mem storage needs metadata for position/boundraries for all images to be fetchable from mapservice.
    • Consider having a dummy map uploaded to flotilla memory interface
  •  Make MapService dependant on storage interface, and not BlobService directly
  • Write Map class to replace BlobItem reference in MapService

Related

How will this change existing functionality?
Easier to run for external companies, less coupling in program

How will this improvement affect the current Threat Model?

@eivindsjovold eivindsjovold added breaking-change A breaking change which introduces changes to the public APIs improvement Improvement to existing functionality epic labels May 2, 2024
@aeshub
Copy link
Contributor

aeshub commented Jul 6, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Jul 6, 2024
@Christdej Christdej removed the stale This issue or pull request already exists label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change which introduces changes to the public APIs epic improvement Improvement to existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants