Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Oracle Database 12.1 (or later) #1628

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

duke147
Copy link

@duke147 duke147 commented Jun 12, 2024

Description

Support Oracle Database 12.1 (or later).

How Has This Been Tested?

Run unit test with command: pytest tests/test_conn_oracle.py
docker run -d -p 1521:1521 -e ORACLE_PASSWORD=oracle gvenzl/oracle-xe:21
sqlplus system/oracle

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@csunny
Copy link
Collaborator

csunny commented Jun 13, 2024

@duke147 Thanks, but too many unrelated code updates, you need to rebase the main and resubmit.

@duke147 duke147 force-pushed the oracle branch 2 times, most recently from e844e43 to 7b840fb Compare June 13, 2024 13:47
@csunny
Copy link
Collaborator

csunny commented Jun 13, 2024

Too many incompatible return type with base class

dbgpt/datasource/rdbms/conn_oracle.py:83: error: "Generator[str, None, None]" has no attribute "difference"  [attr-defined]
dbgpt/datasource/rdbms/conn_oracle.py:90: error: Incompatible types in assignment (expression has type "Generator[str, None, None]", variable has type "set[str]")  [assignment]
dbgpt/datasource/rdbms/conn_oracle.py:188: error: Return type "list[dict[Any, Any]]" of "_get_sample_rows" incompatible with return type "str" in supertype "RDBMSConnector"  [override]
dbgpt/datasource/rdbms/conn_oracle.py:199: error: Return type "list[dict[Any, Any]]" of "_get_table_indexes" incompatible with return type "str" in supertype "RDBMSConnector"  [override]
dbgpt/datasource/rdbms/conn_oracle.py:248: error: Incompatible return value type (got "Any | None", expected "str")  [return-value]
dbgpt/datasource/rdbms/conn_oracle.py:250: error: Return type "tuple[str, str]" of "get_collation" incompatible with return type "str | None" in supertype "BaseConnector"  [override]
dbgpt/datasource/rdbms/conn_oracle.py:263: error: Incompatible return value type (got "tuple[Any | None, Any | None]", expected "tuple[str, str]")  [return-value]

@duke147
Copy link
Author

duke147 commented Jun 24, 2024

@csunny Please take a look and let me know if there's anything else I need to do.

@Aries-ckt
Copy link
Collaborator

@csunny Please take a look and let me know if there's anything else I need to do.

@duke147 docker hub cannot pull gvenzl/oracle-xe:21, now we cannot test oracle, so we will install oracle manually soon.

@duke147
Copy link
Author

duke147 commented Jun 25, 2024

you can try this : docker pull dockerproxy.com/gvenzl/oracle-xe:21

@Aries-ckt
Copy link
Collaborator

@codermast ,Currently, the oracle docker image cannot be pulled down and tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants