Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ~~miette~~ annotate-snippets for reporting errors from invalid Cargo.tomls #42

Open
eopb opened this issue Aug 9, 2024 · 3 comments

Comments

@eopb
Copy link
Owner

eopb commented Aug 9, 2024

https://docs.rs/miette/latest/miette/

https://github.com/rust-lang/annotate-snippets-rs

toml_edit should be able to provide spans we can use: https://docs.rs/toml_edit/latest/toml_edit/?search=span

@eopb
Copy link
Owner Author

eopb commented Aug 20, 2024

We don't do much manual parsing anymore, mostly relying on cargo metadata so there's not much point in doing this

@epage
Copy link
Contributor

epage commented Sep 4, 2024

Do you want to match cargo and use annotate-snippets?

@eopb eopb changed the title Use miette for reporting errors from invalid Cargo.tomls Use ~~miette~~ annotate-snippets for reporting errors from invalid Cargo.tomls Sep 5, 2024
@eopb
Copy link
Owner Author

eopb commented Sep 5, 2024

That's better 👍
I've updated the issue description to suggest annotate-snippets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants