Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objdiff-cli report changes does not account for renames #91

Open
ribbanya opened this issue Aug 12, 2024 · 0 comments
Open

objdiff-cli report changes does not account for renames #91

ribbanya opened this issue Aug 12, 2024 · 0 comments
Labels

Comments

@ribbanya
Copy link
Contributor

It breaks if you rename a function or a translation unit.

The simplest solution would be to compare sections and functions by virtual address, rather than by name. It seems that changes would need to be restructured to compare the sections and functions across the whole project, instead of looping through the translation units. Then maybe they can be regrouped into units before outputting the JSON.

Would any projects have a problem with using virtual addresses instead of names?

@encounter encounter added the cli label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants