Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screenshots are shown up as diff without visual changes #242

Open
IgnaceMaes opened this issue Jul 6, 2024 · 0 comments
Open

Screenshots are shown up as diff without visual changes #242

IgnaceMaes opened this issue Jul 6, 2024 · 0 comments

Comments

@IgnaceMaes
Copy link
Member

In the guides-source repo, the screenshot changes show up as diff. (see e.g. https://github.com/ember-learn/guides-source/pull/2046/files)

This adds extra overhead to reviewing the PRs as it makes it harder to see if there are any actual visual differences.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IgnaceMaes