Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tes): remove filter by status dead code #272

Closed
wants to merge 1 commit into from
Closed

refactor(tes): remove filter by status dead code #272

wants to merge 1 commit into from

Conversation

anantJjain
Copy link
Contributor

Description

Fixes #270

  • This commit refactors the ecc-client-lit-ga4gh-tes-runs
  • Removed the dead client-side code logic for filter by status.
  • Removed the handleStateInput() function responsible for displaying tasks based on their status.
  • Additionally, updated the tesRuns template removing the select by run status drop-down option.

Checklist

  • My code follows the contributing guidelines of this project.
  • I am aware that all my commits will be squashed into a single commit, using the PR title as the commit message.
  • I have performed a self-review of my own code.
  • I have commented my code in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have not reduced the existing code coverage.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2024

⚠️ No Changeset found

Latest commit: 5a64553

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cloud-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 7:46pm

@JaeAeich
Copy link
Contributor

JaeAeich commented May 3, 2024

This PR is removing code from the legacy package which has already been migrated, @anantJjain closing the PR for the same, issue is still valid for the migrated code, please feel free to create a PR for the same on the migrated code.

@JaeAeich JaeAeich closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaeAeich JaeAeich Awaiting requested review from JaeAeich

@SalihuDickson SalihuDickson Awaiting requested review from SalihuDickson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(tes): remove filter by status implementation
2 participants
@anantJjain @JaeAeich