Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tes): remove filter by status implementation #270

Open
JaeAeich opened this issue Mar 17, 2024 · 0 comments
Open

refactor(tes): remove filter by status implementation #270

JaeAeich opened this issue Mar 17, 2024 · 0 comments
Assignees
@anantJjain
Labels
flag: good 1st issue Good for newcomers status: new Has not been triaged by admin type: maintenance Related to general repository maintenance workload: hours Likely takes hours to resolve

Comments

@JaeAeich
Copy link
Contributor

JaeAeich commented Mar 17, 2024 •
edited
Loading

Description

ecc-client-ga4gh-tes-runs (currently ecc-client-lit-ga4gh-tes-runs) has a client-side filter by status implementation. Since the specs don't have such a filter, and client-side solution wasn't ideal the functionality was removed, but it seems there is still some dead code of that logic.

Possible solution(s)

Remove the dead code.

Additional context
@JaeAeich JaeAeich added flag: good 1st issue Good for newcomers status: new Has not been triaged by admin type: maintenance Related to general repository maintenance workload: hours Likely takes hours to resolve labels Mar 17, 2024
@JaeAeich JaeAeich changed the title refactor(wes): remove filter by status implementation refactor(tes): remove filter by status implementation Mar 17, 2024
@anantJjain anantJjain self-assigned this Mar 18, 2024
anantJjain added a commit to anantJjain/cloud-components that referenced this issue Mar 18, 2024
@anantJjain
refactor(tesruns.ts): remove filter by status dead code
5a64553 
fix elixir-cloud-aai#270
@anantJjain anantJjain mentioned this issue Mar 18, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anantJjain anantJjain

Labels
flag: good 1st issue Good for newcomers status: new Has not been triaged by admin type: maintenance Related to general repository maintenance workload: hours Likely takes hours to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(tes): remove filter by status dead code anantJjain/cloud-components
2 participants
@anantJjain @JaeAeich