Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7761 Add ring for group calls #8893

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

Turubaev
Copy link

@Turubaev Turubaev commented Sep 2, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

This PR add ring for group jitsi calls. Also it includes corresponding lab feature, that enable/disable this functionality.

Motivation and context

Absence of ring for group calls degrades the user experience, since users in the group chat are in no way notified that a call has begun. That leads to extra efforts for notifying all chat users that the call has started

This fixes #7761

Tests

  • Prepared 2 physical devices
  • Created group chat with 3 or more users
  • Closed app on device 1
  • Started group call from device 2
  • Declined/Accepted group call from notification

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 13

Checklist

@Turubaev
Copy link
Author

Turubaev commented Sep 2, 2024

Signed-off-by: Turubaev Roman [email protected]

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


[email protected] seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Turubaev
Copy link
Author

Agreement signed
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No ring or notification for incoming Jitsi group call
2 participants