From c85c3f881526056bfd68f1ea14990c42469a1ec2 Mon Sep 17 00:00:00 2001 From: Martijn Laarman Date: Wed, 18 Sep 2024 17:42:51 +0200 Subject: [PATCH 1/2] useSniffing parameter handling was flipped --- src/Elastic.Serilog.Sinks/ElasticsearchSinkExtensions.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Elastic.Serilog.Sinks/ElasticsearchSinkExtensions.cs b/src/Elastic.Serilog.Sinks/ElasticsearchSinkExtensions.cs index fafb58b7..418bfb19 100644 --- a/src/Elastic.Serilog.Sinks/ElasticsearchSinkExtensions.cs +++ b/src/Elastic.Serilog.Sinks/ElasticsearchSinkExtensions.cs @@ -53,7 +53,7 @@ public static LoggerConfiguration Elasticsearch( LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum ) { - var transportConfig = useSniffing ? TransportHelper.Static(nodes) : TransportHelper.Sniffing(nodes); + var transportConfig = !useSniffing ? TransportHelper.Static(nodes) : TransportHelper.Sniffing(nodes); configureTransport?.Invoke(transportConfig); var sinkOptions = new ElasticsearchSinkOptions(new DistributedTransport(transportConfig)); @@ -78,7 +78,7 @@ public static LoggerConfiguration Elasticsearch( LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum ) where TEcsDocument : EcsDocument, new() { - var transportConfig = useSniffing ? TransportHelper.Static(nodes) : TransportHelper.Sniffing(nodes); + var transportConfig = !useSniffing ? TransportHelper.Static(nodes) : TransportHelper.Sniffing(nodes); configureTransport?.Invoke(transportConfig); var sinkOptions = new ElasticsearchSinkOptions(new DistributedTransport(transportConfig)); configureOptions?.Invoke(sinkOptions); From bdea9d362870f1fe5f6114a7c4f04c1df7ee4a69 Mon Sep 17 00:00:00 2001 From: Martijn Laarman Date: Wed, 18 Sep 2024 19:32:20 +0200 Subject: [PATCH 2/2] Switch default of useSniffing to be false to be non breaking --- src/Elastic.Serilog.Sinks/ConfigSinkExtensions.cs | 4 ++-- src/Elastic.Serilog.Sinks/ElasticsearchSinkExtensions.cs | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Elastic.Serilog.Sinks/ConfigSinkExtensions.cs b/src/Elastic.Serilog.Sinks/ConfigSinkExtensions.cs index 94684159..30f1da55 100644 --- a/src/Elastic.Serilog.Sinks/ConfigSinkExtensions.cs +++ b/src/Elastic.Serilog.Sinks/ConfigSinkExtensions.cs @@ -28,7 +28,7 @@ public static LoggerConfiguration Elasticsearch( this LoggerSinkConfiguration loggerConfiguration, BootstrapMethod bootstrapMethod, ICollection nodes, - bool useSniffing = true, + bool useSniffing = false, string? dataStream = null, string? ilmPolicy = null, string? apiKey = null, @@ -58,7 +58,7 @@ public static LoggerConfiguration Elasticsearch( LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum ) { - var transportConfig = !useSniffing ? TransportHelper.Static(nodes) : TransportHelper.Sniffing(nodes); + var transportConfig = useSniffing ? TransportHelper.Sniffing(nodes) : TransportHelper.Static(nodes); SetTransportConfig(transportConfig, apiKey, username, password, proxy, proxyUsername, proxyPassword, fingerprint, debugMode ); diff --git a/src/Elastic.Serilog.Sinks/ElasticsearchSinkExtensions.cs b/src/Elastic.Serilog.Sinks/ElasticsearchSinkExtensions.cs index 418bfb19..659d418e 100644 --- a/src/Elastic.Serilog.Sinks/ElasticsearchSinkExtensions.cs +++ b/src/Elastic.Serilog.Sinks/ElasticsearchSinkExtensions.cs @@ -48,12 +48,12 @@ public static LoggerConfiguration Elasticsearch( ICollection nodes, Action? configureOptions = null, Action? configureTransport = null, - bool useSniffing = true, + bool useSniffing = false, LoggingLevelSwitch? levelSwitch = null, LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum ) { - var transportConfig = !useSniffing ? TransportHelper.Static(nodes) : TransportHelper.Sniffing(nodes); + var transportConfig = useSniffing ? TransportHelper.Sniffing(nodes) : TransportHelper.Static(nodes) ; configureTransport?.Invoke(transportConfig); var sinkOptions = new ElasticsearchSinkOptions(new DistributedTransport(transportConfig)); @@ -73,12 +73,12 @@ public static LoggerConfiguration Elasticsearch( ICollection nodes, Action>? configureOptions = null, Action? configureTransport = null, - bool useSniffing = true, + bool useSniffing = false, LoggingLevelSwitch? levelSwitch = null, LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum ) where TEcsDocument : EcsDocument, new() { - var transportConfig = !useSniffing ? TransportHelper.Static(nodes) : TransportHelper.Sniffing(nodes); + var transportConfig = useSniffing ? TransportHelper.Sniffing(nodes) : TransportHelper.Static(nodes); configureTransport?.Invoke(transportConfig); var sinkOptions = new ElasticsearchSinkOptions(new DistributedTransport(transportConfig)); configureOptions?.Invoke(sinkOptions);