feat: xpert should have z-index priority #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
=======================================
Coverage 81.36% 81.36%
=======================================
Files 13 13
Lines 220 220
Branches 30 30
=======================================
Hits 179 179
Misses 39 39
Partials 2 2 ☔ View full report in Codecov by Sentry. |
alangsto
force-pushed
the
alangsto/fix_component_z_index
branch
from
c233ae0
to
ba342b7
Compare
varshamenon4
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the new sidebar components have been released to prod, and in rendering have a higher z-index, we need to manually set the z-index for Xpert to ensure that it overlays on top of other components visible in the courseware.
Before:
After:
