From ec859b7f1f8c0114deed32137199a4d192499e68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edgar=20Ram=C3=ADrez=20Mondrag=C3=B3n?= Date: Wed, 29 Nov 2023 03:51:08 -0600 Subject: [PATCH] test: Test with singer-sdk prerelease --- poetry.lock | 8 ++++---- pyproject.toml | 4 ++-- tap_jotform/client.py | 14 -------------- 3 files changed, 6 insertions(+), 20 deletions(-) diff --git a/poetry.lock b/poetry.lock index c4d7591..0ba070e 100644 --- a/poetry.lock +++ b/poetry.lock @@ -1250,13 +1250,13 @@ files = [ [[package]] name = "singer-sdk" -version = "0.35.2" +version = "0.36.0rc1" description = "A framework for building Singer taps" optional = false python-versions = ">=3.8" files = [ - {file = "singer_sdk-0.35.2-py3-none-any.whl", hash = "sha256:771c7e0b9a4da0e193f5bd4a5b79bf33f6783f189c6fc13aaa38c18663e90afd"}, - {file = "singer_sdk-0.35.2.tar.gz", hash = "sha256:e8763759660baa4636f2956532227f924a303ce1ff2f40ca92acc910e516f793"}, + {file = "singer_sdk-0.36.0rc1-py3-none-any.whl", hash = "sha256:a92cd4c2bedbfe24987039b0f35451385e1d226f7d32e8b3eb9004f1e7578dd6"}, + {file = "singer_sdk-0.36.0rc1.tar.gz", hash = "sha256:188eca5b884fbbd1ae2353b7013fec205fe915c5eadd506833898ede9dd47fb0"}, ] [package.dependencies] @@ -1490,4 +1490,4 @@ testing = ["big-O", "jaraco.functools", "jaraco.itertools", "more-itertools", "p [metadata] lock-version = "2.0" python-versions = ">=3.8" -content-hash = "468256f27612f4e6b01061bfb5280cb10eb81ff79334dba5d32c0df8c3143643" +content-hash = "f62e824470063271949f3b8ce9a0df372580f36a021759ca6c399a903b3d3b29" diff --git a/pyproject.toml b/pyproject.toml index c4169cd..7f4fc17 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -22,12 +22,12 @@ keywords = ["ELT", "Jotform"] python = ">=3.8" colorama = "==0.4.*" requests-cache = "==1.2.*" -singer-sdk = "==0.35.*" +singer-sdk = { version = "==0.36.0rc1", allow-prereleases = true } structlog = "==24.1.*" [tool.poetry.group.dev.dependencies] pytest = "==8.*" -singer-sdk = { version = "==0.35.*", extras = ["testing"] } +singer-sdk = { version = "==0.36.0rc1", allow-prereleases = true, extras = ["testing"] } [tool.poetry.scripts] # CLI declaration diff --git a/tap_jotform/client.py b/tap_jotform/client.py index 3582fb5..058c8de 100644 --- a/tap_jotform/client.py +++ b/tap_jotform/client.py @@ -14,20 +14,6 @@ class JotformPaginator(BaseOffsetPaginator): """Jotform pagination class.""" - def has_more(self, response: requests.Response) -> bool: - """Return True if there are more pages to fetch. - - Args: - response: The response object from the last request. - - Returns: - True if there are more pages to fetch, False otherwise. - """ - result_set = response.json()["resultSet"] - count = int(result_set["count"]) - - return count == self._page_size - class JotformStream(RESTStream): """Jotform stream class."""