Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev/1.0.0]Should ZBytes.__new__ be replaced with ZBytes.serialize? #283

Open
wyfo opened this issue Aug 27, 2024 · 1 comment
Open

[dev/1.0.0]Should ZBytes.__new__ be replaced with ZBytes.serialize? #283

wyfo opened this issue Aug 27, 2024 · 1 comment
Labels
release Part of the next release

Comments

@wyfo
Copy link
Contributor

wyfo commented Aug 27, 2024

Describe the release item

@Mallets

@wyfo wyfo added the release Part of the next release label Aug 27, 2024
@wyfo
Copy link
Contributor Author

wyfo commented Sep 9, 2024

We agreed on:

  • use a class method constructor serialize working the same way as the current constructor
  • modify the constructor signature to only accept bytes (actually, I would like to use collection.abc.Buffer, but it requires Python3.12), making the intent clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Part of the next release
Projects
Status: No status
Development

No branches or pull requests

1 participant