Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the type be uint8_t instead of size_t for serialize_v1p(...) in srv_state.hxx line 133 #464

Open
sldr opened this issue Aug 27, 2023 · 1 comment

Comments

@sldr
Copy link
Contributor

sldr commented Aug 27, 2023

ptr<buffer> serialize_v1p(size_t version) const {

or if it really needs to be size_t then maybe static_cast<uint8_t>() around bs.put_u8(version);

VS 2022 is complaining about it.

Thanks,
SLDR

@greensky00
Copy link
Contributor

Ok, thanks. Would you mind submitting a PR for it? Or please let me know if you want me to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants