Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for reading lists #292

Merged
merged 15 commits into from
Apr 17, 2024
Merged

feat: add support for reading lists #292

merged 15 commits into from
Apr 17, 2024

Conversation

Mause
Copy link
Member

@Mause Mause commented Apr 13, 2024

@Swoorup if you have a chance to review this design, I'd appreciate it as well

@Mause Mause requested a review from Maxxen April 13, 2024 16:55
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 61.11111% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 62.83%. Comparing base (b82db39) to head (a033f66).
Report is 1 commits behind head on main.

Files Patch % Lines
src/types/mod.rs 36.36% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
+ Coverage   61.50%   62.83%   +1.32%     
==========================================
  Files          36       36              
  Lines        2146     2209      +63     
==========================================
+ Hits         1320     1388      +68     
+ Misses        826      821       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mause Mause changed the title feat: add support to read lists feat: add support for reading lists Apr 13, 2024
Copy link
Contributor

@Swoorup Swoorup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine by me.

@Maxxen Maxxen merged commit 8eaf5de into duckdb:main Apr 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants