Skip to content

Commit

Permalink
enable union test
Browse files Browse the repository at this point in the history
  • Loading branch information
Mause committed Apr 25, 2024
1 parent b5f2de3 commit abdfbf8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
6 changes: 1 addition & 5 deletions src/test_all_types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,7 @@ fn test_all_types() -> crate::Result<()> {

let excluded = [
// uhugeint, time_tz, and dec38_10 aren't supported in the duckdb arrow layer
"uhugeint",
"time_tz",
"dec38_10",
// union is currently blocked by https://github.com/duckdb/duckdb/pull/11326
"union",
"uhugeint", "time_tz", "dec38_10",
];

let mut binding = database.prepare(&format!(
Expand Down
4 changes: 2 additions & 2 deletions src/types/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,8 @@ impl From<&DataType> for Type {
.map(|f| (f.name().to_owned(), Type::from(f.data_type())))
.collect(),
),
// DataType::Union(_, _) => Self::Union,
// DataType::Dictionary(_, _) => Self::Enum,
DataType::Union(_, _) => Self::Union,
DataType::Dictionary(_, _) => Self::Enum,
DataType::Decimal128(..) => Self::Decimal,
DataType::Decimal256(..) => Self::Decimal,
DataType::Map(field, ..) => {
Expand Down

0 comments on commit abdfbf8

Please sign in to comment.