Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cPanel review of v0.33 #1

Open
drmuey opened this issue Jan 24, 2015 · 0 comments
Open

cPanel review of v0.33 #1

drmuey opened this issue Jan 24, 2015 · 0 comments

Comments

@drmuey
Copy link
Owner

drmuey commented Jan 24, 2015

Using git hub to track since I need to upload before this is complete.

All major stakeholders aside from cPanel has signed off on this feature and implementation.

So we need to review it from cPanel’s point of view and adjust if necessary.

Change:

  1. dc1d043
  2. Create rt 101721 for L::M::U followup

Testing:

  1. All 699366 tests pass (including the new tests for this feature and RELEASE_TESTING)
  2. Locale::Maketext used to 'use if' so it was ok for perlcc via 5.6.
  3. 'use if' works with perlcc **
  4. will not effect cPanel behavior at this time because it uses the default behavior and because an internal version is used

**

Basic 'use if' compile test:

# cat tmp/useif.pl
use if $ENV{UNI}, "utf8";

print length("I ☃") . "\n";
# perl tmp/useif.pl
5
# UNI=1 perl tmp/useif.pl
3
#  perlcc tmp/useif.pl -o tmp/useif
# tmp/useif
5
# UNI=1 perlcc tmp/useif.pl -o tmp/useif
3
# 

lazy load at runtime that does use if technique this change does:

# cat uif.pl 
use You;
print You::pl() . "\n";
# cat You.pm 
package You;

use strict;
use warnings;
our $VAR = 0;
sub import {
   $VAR = 1;
}

sub pl { 
     require You::Too;
     return You::Too::me();
}
1;
# cat You/Too.pm 
package You::Too;

use strict;
use warnings;
use if $You::VAR, 'utf8';

sub me {
    return length("español"); # 8 bytes for 7 character
}

1;
# perlcc uif.pl
# ./uif 
7
#

change it to have the var be false and the result is 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant