Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and enable on Mac OS #8

Open
soccer99 opened this issue Apr 21, 2020 · 2 comments
Open

Test and enable on Mac OS #8

soccer99 opened this issue Apr 21, 2020 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@soccer99
Copy link

Describe the bug
I cannot install this package on my Mac

npm install --save @dreamonkey/responsive-image-loader

npm ERR! code EBADPLATFORM
npm ERR! notsup Unsupported platform for @dreamonkey/[email protected]: wanted {"os":"linux","arch":"any"} (current: {"os":"darwin","arch":"x64"})
npm ERR! notsup Valid OS: linux
npm ERR! notsup Valid Arch: any
npm ERR! notsup Actual OS: darwin
npm ERR! notsup Actual Arch: x64

To Reproduce
Install using npm on mac

node v10.15.1 (npm v6.13.7)

Desktop (please complete the following information):

  • OS: Mac 10.15
  • Version 10.15.3
@soccer99 soccer99 added the bug Something isn't working label Apr 21, 2020
@IlCallo IlCallo added the help wanted Extra attention is needed label Apr 21, 2020
@IlCallo
Copy link
Member

IlCallo commented Apr 21, 2020

Hi @soccer99, the package is still under development and some feature still hasn't been tested on SO different than Linux (I don't have a Mac so I cannot test on your system), that's why I added the "os": [ "linux" ] constraint to the package.json.

Especially paths management and Thumbor setup (they are currently writing the next major release and aren't answering any issue on their repo on this regard).

Feel free to:

  • clone the repo
  • setup Thumbor (if you want to use Art Direction)
  • locally disable the OS constraint
  • build the loader with yarn build
  • locally reference the built loader (yarn add file:./path/to/responsive-image-loader/)
  • check that everything works fine with mac :)

All needed info should be present into the CONTRIBUTING and DEV_ENVIRONMENT files (tel me if something is missing).

Note that currently there are some problems with tests (some race condition with Thumbor cache apparently) and they sometimes fail with Module build failed (from ../node_modules/raw-loader/dist/cjs.js): TypeError: Cannot read property 'replace' of undefined.

Re-execute tests 2-3 times will remove these errors.
I'm deploying a new version with updated deps right now.

Related
dreamonkey/responsive-image-loader#3
dreamonkey/responsive-image-loader#22

@IlCallo IlCallo changed the title Installation Unsupported platform for @dreamonkey/[email protected] Test and enable on Mac OS Apr 21, 2020
@IlCallo
Copy link
Member

IlCallo commented Sep 14, 2020

@soccer99 hey there, can you check out if new thumbor-docker engine works on Mac too? We tested it on Windows and Linux for now
Version 0.4.1 contains the needed changes dreamonkey/responsive-image-loader#38

@IlCallo IlCallo transferred this issue from dreamonkey/responsive-image-loader Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants