Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctr-remote is poorly maintained and currently uses many deprecated APIs #1190

Open
adamqqqplay opened this issue Mar 31, 2023 · 6 comments · May be fixed by #1623
Open

ctr-remote is poorly maintained and currently uses many deprecated APIs #1190

adamqqqplay opened this issue Mar 31, 2023 · 6 comments · May be fixed by #1623
Labels
enhancement New feature or request

Comments

@adamqqqplay
Copy link
Member

ctr-remote has only upgraded dependency related maintenance for a long time, in a recent dependency upgrade, golangci-lint reported many deprecated API calls: https://github.com/dragonflyoss/image-service/actions/runs/4571843533/jobs/8070513996

golangci-lint run
Error: commands/rpull.go:94:3: SA1019: containerd.WithSchema1Conversion is deprecated: use Schema 2 or OCI images. (staticcheck)
		containerd.WithSchema1Conversion,
		^
Error: cmd/main.go:30:2: SA1019: seed.WithTimeAndRand is deprecated: Do not rely on the global seed. (staticcheck)
	seed.WithTimeAndRand()
	^
Error: cmd/main.go:24:2: SA1019: "github.com/containerd/containerd/pkg/seed" is deprecated: Do not rely on the global seed. (staticcheck)
	"github.com/containerd/containerd/pkg/seed"
	^

We should replace these deprecated APIs in the future, otherwise it may not be compatible with containerd 1.7.

@adamqqqplay adamqqqplay added the enhancement New feature or request label Mar 31, 2023
@changweige
Copy link
Contributor

Do we still need ctr-remote?

@imeoer
Copy link
Collaborator

imeoer commented Mar 31, 2023

Maybe the nerdctl support is enough for users.

@jiangliu
Copy link
Collaborator

so let's deprecate it?

@adamqqqplay
Copy link
Member Author

Maybe we could migrate ctr-remote to nydusify rpull to reduce maintenance cost, like soci: https://github.com/awslabs/soci-snapshotter/blob/main/docs/getting-started.md#lazily-pull-image

@imeoer
Copy link
Collaborator

imeoer commented Apr 6, 2023

Maybe we could migrate ctr-remote to nydusify rpull to reduce maintenance cost, like soci

We still need to provide run command etc, better to use nerdctl as the replacement.

@adamqqqplay
Copy link
Member Author

Maybe we could migrate ctr-remote to nydusify rpull to reduce maintenance cost, like soci

We still need to provide run command etc, better to use nerdctl as the replacement.

Yeah, that sounds great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants