From b72149ddbc702330dd096a2dfb1b63f3151eba47 Mon Sep 17 00:00:00 2001 From: Matt Budz Date: Thu, 5 Sep 2024 17:38:00 +0200 Subject: [PATCH 1/4] fix manually triggered CI runs erroring out --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 25e7a7a57..99c8f409a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -32,6 +32,7 @@ jobs: IS_MERGE: ${{ github.base_ref == '' }} PREV_SHA: ${{ github.event.before }} TARGET_BRANCH: ${{ github.base_ref }} + FALLBACK_BRANCH: 'origin/develop' steps: - name: Checkout code uses: actions/checkout@v1 @@ -40,7 +41,7 @@ jobs: with: bundler-cache: true - name: Lint changed files - run: bin/rubocop-ci ${{ env.TARGET_BRANCH || env.PREV_SHA }} ${{ env.IS_MERGE }} + run: bin/rubocop-ci ${{ env.TARGET_BRANCH || env.PREV_SHA || env.FALLBACK_BRANCH }} ${{ env.IS_MERGE }} rspec: name: RSpec needs: [audits, rubocop] From 3b3bfcc8cb7439a824b7c75d6d05273542d933ee Mon Sep 17 00:00:00 2001 From: Daniel Martin <53006+etdsoft@users.noreply.github.com> Date: Sun, 8 Sep 2024 11:02:26 +0200 Subject: [PATCH 2/4] Layout - use dradis.com domain --- app/views/layouts/application.html.erb | 2 +- app/views/layouts/setup.html.erb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index 8d9fd7697..9b5f03ce5 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -25,7 +25,7 @@ <%= yield %> diff --git a/app/views/layouts/setup.html.erb b/app/views/layouts/setup.html.erb index 0e8a24167..144071e5b 100644 --- a/app/views/layouts/setup.html.erb +++ b/app/views/layouts/setup.html.erb @@ -23,7 +23,7 @@ <%= yield %> - + From 93aa6601031cfa32210fd8e9f0d6101c09af6b5f Mon Sep 17 00:00:00 2001 From: Daniel Martin <53006+etdsoft@users.noreply.github.com> Date: Sun, 8 Sep 2024 11:40:27 +0200 Subject: [PATCH 3/4] Layout - use https:// URLs --- app/views/layouts/application.html.erb | 2 +- app/views/layouts/setup.html.erb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index 9b5f03ce5..ef32e0ade 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -25,7 +25,7 @@ <%= yield %> diff --git a/app/views/layouts/setup.html.erb b/app/views/layouts/setup.html.erb index 144071e5b..054b6db28 100644 --- a/app/views/layouts/setup.html.erb +++ b/app/views/layouts/setup.html.erb @@ -23,7 +23,7 @@ <%= yield %> - + From 26e6a3689b8b279b28e2a3311b5b2d41e6a50f6a Mon Sep 17 00:00:00 2001 From: Daniel Martin <53006+etdsoft@users.noreply.github.com> Date: Sun, 8 Sep 2024 11:45:21 +0200 Subject: [PATCH 4/4] Layouts#navbar - add UTM params --- app/views/layouts/tylium/navbar/_help.html.erb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/views/layouts/tylium/navbar/_help.html.erb b/app/views/layouts/tylium/navbar/_help.html.erb index 94bb6dc2f..6295de67c 100644 --- a/app/views/layouts/tylium/navbar/_help.html.erb +++ b/app/views/layouts/tylium/navbar/_help.html.erb @@ -5,8 +5,8 @@