Fixes writing unwanted characters to console when TerminalLogger is created directly #10678
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKrivanek
approved these changes
Sep 19, 2024
rainersigwald
approved these changes
Sep 19, 2024
maridematte
approved these changes
Sep 19, 2024
This reverts commit 4f6071c.
|
Reverted version bump (we haven't gone to final versioning in 17.12 yet) and merging on red for that check. |
rainersigwald
deleted the
dev/mipavlik/fix-terminallogger-unwanted-characters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10579
Summary
Command
dotnet runcreatesTerminalLoggerinstance and bypasses code that enables VIRTUAL_TERMINAL_PROCESSING on Windows. This can cause rendering of unwanted VT100 control codes in the console.Customer Impact
Customer see "weird" characters on terminal that doesn't have enabled VT100 support by default - mostly conhost. Reproduces in
dotnet new console && dotnet runscenario.Regression?
Yes, in RC2 from enhanced console output in
dotnet runin dotnet/sdk#42240.Testing
Manual testing. Before and after the fix:
Risk
Low. The same logic is used when MSBuild is started via entry point.