Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown link checker can't handle the case where Dockerfiles are added or moved #5871

Open
lbussell opened this issue Sep 10, 2024 · 1 comment

Comments

@lbussell
Copy link
Contributor

The auto-generated tags tables contain absolute links to the individual Dockerfiles for each image.

If you submit a PR that moves Dockerfiles like this one, then the link checker will always fail since the links are not live yet (the PR has not been merged and the files don't exist).

Related: #5818
/cc @MichaelSimons

@lbussell
Copy link
Contributor Author

[Triage]

Some potential solution ideas:

  • Use relative links in tags tables since the tags table is no longer posted to DockerHub
  • Accept merging on red
  • Only run the markdown link checker on a schedule so that it only checks the live markdown files.

Of these, the first seems the most promising. It would still fail when adding new Docker repos, but that is infrequent enough that it's not a big issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Current Release
Development

No branches or pull requests

1 participant