Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical log on quic connection timeout #57933

Open
amcasey opened this issue Sep 17, 2024 · 3 comments · May be fixed by #57934
Open

Critical log on quic connection timeout #57933

amcasey opened this issue Sep 17, 2024 · 3 comments · May be fixed by #57934
Assignees
@amcasey
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions HTTP3

Comments

@amcasey
Copy link
Member

amcasey commented Sep 17, 2024

Toy repro: launch server, launch client, wait ~20 seconds

Server

using Microsoft.AspNetCore.Server.Kestrel.Core;

var builder = WebApplication.CreateBuilder(args);

builder.WebHost.ConfigureKestrel(options =>
{
    options.ListenLocalhost(5001, listenOptions =>
    {
        listenOptions.Protocols = HttpProtocols.Http3;
        listenOptions.UseHttps();
    });

    options.Limits.KeepAliveTimeout = TimeSpan.FromSeconds(5);
});

var app = builder.Build();

app.MapGet("/", () => "Hello, world!");

app.Run();

Client

using var client = new HttpClient()
{
    BaseAddress = new Uri("https://localhost:5001"),
    DefaultRequestVersion = new Version(3, 0),
    DefaultVersionPolicy = HttpVersionPolicy.RequestVersionExact,
};

try
{
    var response = await client.GetAsync("/");
    response.EnsureSuccessStatusCode();

    var data = await response.Content.ReadAsStringAsync();
    Console.WriteLine(data);
}
catch (HttpRequestException e)
{
    Console.WriteLine($"Request error: {e.Message}");
}

Originally posted by @amcasey in #45105 (comment)
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Sep 17, 2024
@amcasey
Copy link
Member Author

amcasey commented Sep 17, 2024 

crit: Microsoft.AspNetCore.Server.Kestrel[0]
      Unexpected exception in HttpConnection.ProcessRequestsAsync.
      System.ArgumentOutOfRangeException: A value between 0x0 and 0x3fffffffffffffff is required. (Parameter 'errorCode')
      Actual value was -1.
         at Microsoft.AspNetCore.Server.Kestrel.Transport.Quic.QuicTransportOptions.ValidateErrorCode(Int64 errorCode)
         at Microsoft.AspNetCore.Server.Kestrel.Transport.Quic.Internal.QuicConnectionContext.set_Error(Int64 value)
         at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http3.Http3Connection.Abort(ConnectionAbortedException ex, Http3ErrorCode errorCode, ConnectionEndReason reason)
         at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http3.Http3Connection.ProcessRequestsAsync[TContext](IHttpApplication`1 application)
         at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.HttpConnection.ProcessRequestsAsync[TContext](IHttpApplication`1 httpApplication)

@amcasey
Copy link
Member Author

amcasey commented Sep 17, 2024

This validation was added in #55282.

@amcasey
Copy link
Member Author

amcasey commented Sep 17, 2024 •
edited
Loading

I wonder if we just need to check for -1 (no error code set) here

aspnetcore/src/Servers/Kestrel/Core/src/Internal/Http3/Http3Connection.cs

Line 549 in ffd5a38

Abort(CreateConnectionAbortError(error, clientAbort), (Http3ErrorCode)_errorCodeFeature.Error, reason);

@amcasey amcasey added the HTTP3 label Sep 17, 2024
@amcasey amcasey self-assigned this Sep 17, 2024
amcasey added a commit to amcasey/aspnetcore that referenced this issue Sep 18, 2024
@amcasey
Check for sentinel value when setting HTTP/3 error code
d87133f 
If no error code has been set, `IProtocolErrorFeature.Error` will be `-1`.  If we pass that through verbatim, it will be caught by validation in the setter (ironically, of the same property on the same feature object), resulting in an exception and a Critical (but apparently benign) log message.

Fixes dotnet#57933
This was referenced Sep 18, 2024
Open
Open
amcasey added a commit to amcasey/aspnetcore that referenced this issue Sep 19, 2024
@amcasey
Check for sentinel value when setting HTTP/3 error code
b30eee2 
If no error code has been set, `IProtocolErrorFeature.Error` will be `-1`.  If we pass that through verbatim, it will be caught by validation in the setter (ironically, of the same property on the same feature object), resulting in an exception and a Critical (but apparently benign) log message.

Fixes dotnet#57933
@amcasey amcasey mentioned this issue Sep 19, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amcasey amcasey

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions HTTP3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for sentinel value when setting HTTP/3 error code amcasey/aspnetcore
1 participant
@amcasey