Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description with spaces and MethodTitle quotes #1715

Open
lipchev opened this issue May 23, 2021 · 0 comments · May be fixed by #2184
Open

Description with spaces and MethodTitle quotes #1715

lipchev opened this issue May 23, 2021 · 0 comments · May be fixed by #2184
Assignees
@YegorStepanov

Comments

@lipchev
Copy link

lipchev commented May 23, 2021

I've noticed that having a white space in the Description of a benchmark causes additional quotes to be added to the MethodTitle (all exporters).

Method Mean Error StdErr Min Max Median Ratio MannWhitney(5%) Gen 0 Gen 1 Gen 2 Allocated
'new (value, unit)' 743.6 ns NA 0.0 ns 743.6 ns 743.6 ns 743.6 ns 1.00 Base - - - -
FromUnit(quantityValue) 1,395.2 ns NA 0.0 ns 1,395.2 ns 1,395.2 ns 1,395.2 ns 1.88 ? - - - -
Quantity.From(value,unit) 3,785.3 ns NA 0.0 ns 3,785.3 ns 3,785.3 ns 3,785.3 ns 5.09 ? - - - 32 B
'Quantity<Q,U>.From(value, unit)' 5,232.6 ns NA 0.0 ns 5,232.6 ns 5,232.6 ns 5,232.6 ns 7.04 ? - - - 56 B
'Quantity.From(value, randomUnit)' 8,620.2 ns NA 0.0 ns 8,620.2 ns 8,620.2 ns 8,620.2 ns 11.59 ? - - - 32 B

This was also the case in v0.12 I just really noticed it now when I tried to 'echo' a json string
YegorStepanov added a commit to YegorStepanov/BenchmarkDotNet that referenced this issue Nov 1, 2022
@YegorStepanov
Fix dotnet#1715
80f1e11
@YegorStepanov YegorStepanov linked a pull request Nov 1, 2022 that will close this issue
Draft
YegorStepanov added a commit to YegorStepanov/BenchmarkDotNet that referenced this issue Nov 1, 2022
@YegorStepanov
Revert "Fix dotnet#1715"
a15545b 
This reverts commit 80f1e11.
YegorStepanov added a commit to YegorStepanov/BenchmarkDotNet that referenced this issue Nov 1, 2022
@YegorStepanov
Fix dotnet#1715 with the ability to revert the old behavior
b703454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YegorStepanov YegorStepanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1715 YegorStepanov/BenchmarkDotNet
2 participants
@lipchev @YegorStepanov