Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document 412 status code in "Response Codes" section #132

Open
3flex opened this issue Dec 20, 2016 · 0 comments
Open

Document 412 status code in "Response Codes" section #132

3flex opened this issue Dec 20, 2016 · 0 comments
Labels
documentation Updates on the documentation and support content.

Comments

@3flex
Copy link
Contributor

3flex commented Dec 20, 2016

This appears to be used only when attempting to enable vanity codes but they're not enabled for the current plan. Code's not mentioned in https://developer.dnsimple.com/v2/#response-codes.

Something confusing related to this is that enabling vanity servers when plan doesn't support it returns 412 with this response:

{
  "message": "Feature not enabled: vanity_name_servers"
}

But attempting to set regions on a record when plan doesn't support it returns 400 with this response:

{
  "message": "Regions are not allowed for your plan.",
  "errors": {}
}

The inconsistent error codes make it difficult to handle a "feature not enabled" response from the server. Sorry I know this isn't documentation related but not sure where it's best to bring it up. Having a different code from 400 (which I read as being invalid JSON input in the request body) would be useful.

@weppos weppos added documentation Updates on the documentation and support content. and removed enhancement labels Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Updates on the documentation and support content.
Projects
None yet
Development

No branches or pull requests

3 participants