Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge this branch with Keras 2.0 #66

Open
rravu3 opened this issue Jun 14, 2017 · 15 comments
Open

Merge this branch with Keras 2.0 #66

rravu3 opened this issue Jun 14, 2017 · 15 comments

Comments

@rravu3
Copy link

rravu3 commented Jun 14, 2017

Hi,

Wanted to ask what are the plans to pull in Keras 2.0 as there have been interface level changes from 1.2.2.

Rahul

@kevinthesun
Copy link

Yes. We will first finalize keras/mxnet for 1.2.2 and then switch to 2.0.

@yliu7366
Copy link

Waiting for MXNet + Keras 2. I have networks developed based on Keras 2 and I am desperate for MXNet auto multi-GPU support....

@TimZaman
Copy link

@kevinthesun timeline? Why not try to merge this into Keras?

@edmondja
Copy link

:'( same as @yliu7366 I hope at least somebody has begun to work on this

@davideboschetto
Copy link

It would be great to have an update: are things still planned for a Keras2.0 upgrade?

@kevinthesun
Copy link

@sandeep-krishnamurthy

@sandeep-krishnamurthy
Copy link

sandeep-krishnamurthy commented Oct 26, 2017

Hi Yes. This is planned and work is in progress. I have implemented all basic tensor operators.. https://github.com/simpledl/keras/tree/mxnet_backend_keras2
Note above repo is just a placeholder I started working on. All work we do on Keras 2 will go to a PR on Keras 2.

@davideboschetto
Copy link

This is great @sandeep-krishnamurthy !
Keep up the good work, having the backend in keras2 would be amazing, thanks!
Do you by any chance have a ballpark estimation for when the PR will come?

@sandeep-krishnamurthy
Copy link

Hello,
Keras2+MXNet is almost complete. https://github.com/deep-learning-tools/keras/tree/keras2_mxnet_backend . Please try and provide your feedback.

I have created a PR - keras-team#9291
However, there are few design incompatibility with MXNet and Keras in the way Model compile and Optimizers are handled. Hence, few changes are requested by Keras community. These changes require significant modifications in MXNet Module and KVStore components. Hence, we talked to keras community to release the fork for the benefit of Keras users as the interface remains the same.

@edmondja
Copy link

edmondja commented Mar 24, 2018

@sandeep-krishnamurthy How to install the Keras2-compatible version ?

@sandeep-krishnamurthy
Copy link

@edmondja - Thanks for you interest.
Please open issue at - https://github.com/deep-learning-tools/keras if you face any problems.

$ mkdir keras
$ git clone https://github.com/deep-learning-tools/keras ./keras/
$ cd keras/

# MXNet backend code is in keras2_mxnet_backend branch. Check it out.
$ git fetch
$ git checkout keras2_mxnet_backend
$ git pull

# Install Keras
$ sudo python setup.py install

@edmondja
Copy link

Hello, I used all of your instructions but I have this error :

File "/Users/edmondjacoupeau/anaconda/lib/python3.6/site-packages/keras/backend/init.py", line 72, in
assert _backend in {'theano', 'tensorflow', 'cntk'}

AssertionError

@sandeep-krishnamurthy
Copy link

sandeep-krishnamurthy commented Mar 27, 2018

Hi @edmondja It looks like you have not checked out keras2_mxnet_backend branch. Can you please confirm?
Because, in init.py you should see assert_backend in {'theano', 'tensorflow', 'cntk', 'mxnet'} like this
https://github.com/deep-learning-tools/keras/blob/keras2_mxnet_backend/keras/backend/__init__.py#L72

@sandeep-krishnamurthy
Copy link

@edmondja - Did you had pre-installed keras (without mxnet backend)? If yes, please uninstall it before running above provided command.

$ pip uninstall keras

@edmondja
Copy link

edmondja commented Sep 5, 2018

Thanks it worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants