Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FacialCycles and DualGraph #703

Open
MeikeWeiss opened this issue Sep 12, 2024 · 1 comment
Open

Implement FacialCycles and DualGraph #703

MeikeWeiss opened this issue Sep 12, 2024 · 1 comment
Labels
new-feature A label for new features.

Comments

@MeikeWeiss
Copy link
Contributor

I have already an implementation of a method that computes for a digraph and a rotation system the facial cycles (no matter whether the graph is planar or not) and a method that computes the dual graph of a planar digraph. Before I make the pull request, I wanted to ask if you have any suggestions as to which chapter it would best fit into.
@james-d-mitchell james-d-mitchell added the new-feature A label for new features. label Sep 12, 2024
@james-d-mitchell
Copy link
Member

Thanks for the suggestion @MeikeWeiss, probably the best place for FacialCycles would be chapter 4 (where DigraphAllSimpleCycles is documented), and for DualGraph in Chapter 5 in the planarity section. You might consider choosing a different name for DualGraph since we already have DualDigraph with rather a different meaning. Maybe something like DualPlanarGraph or similar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new-feature A label for new features.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@james-d-mitchell @MeikeWeiss